Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog source affinity #2963

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented May 5, 2023

Description of the change:

Add affinity customization to catalog sources

Closes #2960

Motivation for the change:

Enable multi-architecture catalog images to limit scheduling to their supported architectures.

Architectural changes:

n/a

Testing remarks:

Basically a copy paste of the same thing for tolerations.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2023

Hi @Jamstah. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jamstah
Copy link
Contributor Author

Jamstah commented May 5, 2023

Opened as a draft, partly to let the tests run, and partly to ask a question.

The API change hasn't been put into a release yet - is that something I should wait for before finalizing the PR?

@Jamstah Jamstah force-pushed the catalog-source-affinity branch 2 times, most recently from ffba91e to 0a7c65d Compare May 5, 2023 17:22
@Jamstah Jamstah marked this pull request as ready for review May 16, 2023 15:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@openshift-ci openshift-ci bot requested review from dtfranz and exdx May 16, 2023 15:02
@perdasilva
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2023
@perdasilva
Copy link
Collaborator

Opened as a draft, partly to let the tests run, and partly to ask a question.

The API change hasn't been put into a release yet - is that something I should wait for before finalizing the PR?

Hi @Jamstah - thanks heaps for this ^^
Yeah, I think we should cut a release of the api repo, then update the mod file to point to it before we can merge this PR.
I'll reach out to the team to see if we can get that happening.

@Jamstah
Copy link
Contributor Author

Jamstah commented May 22, 2023

Great. LMK when that's happened and I can rebase and revendor.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah
Copy link
Contributor Author

Jamstah commented Jul 6, 2023

OK, should be all done.

@kevinrizza
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jamstah, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit f8b1721 into operator-framework:master Jul 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add affinity customization to catalog source grpc pods
4 participants