Update to k8s v0.28.5 and other operator-framework components #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meant to... |
openshift-ci
bot
added
do-not-merge/hold
tmshort
force-pushed
the
k8s28
branch
3 times, most recently
from
bb6574f
to
ec8f0ff
Compare
This also updates to the latest operator-framework api and operator-registry kind is still at v0.20.0 (k8s 1.27.3) as it's the latest version Signed-off-by: Todd Short <todd.short@me.com>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
grokspawn
previously approved these changes
Jan 15, 2024
|
/lgtm |
Fix unit-tests as well Signed-off-by: Todd Short <todd.short@me.com>
Hack `scripts/update_codegen.sh` script to continue to generate code using the deprecated scripts. The deprecated scripts now call into each other, and unfortunately, `go mod vendor` doesn't keep permission bits around. So, we need to update the execute permissions on a vendored script. The new `kube_codegen.sh` doesn't work when the repository path is outside the package name, see: kubernetes/code-generator#165 The workaround is to create symlinked directories to fool `kube_codegen.sh` into thinking the path is correct. But first we'd have to start using the new script. Once `kube_codegen.sh` is fixed, we should migrate to it (which is a non-trivial task). Signed-off-by: Todd Short <todd.short@me.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:master
with commit Jan 15, 2024
134ccee
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Summary
Updates to latest operator-framework/api and operator-framework/operator-registry, which requires updates to k8s v0.28.x (v0.28.5 in this case).
Update code to be compatible with these updated dependencies.
kindis kinda stuck at k8s 1.27.3, so I couldn't update the testing for that.Update k8s to v0.28.5
This also updates to the latest operator-framework api and operator-registry
kindis still at v0.20.0 (k8s 1.27.3) as it's the latest versionUpdate code for k8s v0.28.5 compatibility
Fix unit-tests as well
Update codegen
Hack
scripts/update_codegen.shscript to continue to generate code using the deprecated scripts. The deprecated scripts now call into each other, and unfortunately,go mod vendordoesn't keep permission bits around.So, we need to update the execute permissions on a vendored script.
The new
kube_codegen.shdoesn't work when the repository path is outside the package name, see:kubernetes/code-generator#165
The workaround is to create symlinked directories to fool
kube_codegen.shinto thinking the path is correct. But first we'd have to start using the new script.Once
kube_codegen.shis fixed, we should migrate to it (which is a non-trivial task).Motivation for the change:
operator-framework/api and operator-framework/operator-registry have been updated to k8s v0.28.x
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue