Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slash command access to make unit #3186

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Mar 5, 2024

Description of the change:
This should allow PR comments of the form:
/retest unit to trigger make unit

Motivation for the change:
Prow offers PR comments to trigger fine-grained retest capabilities for tests. This trials adding this capability for the unit test target.

Architectural changes:

None

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

.github/workflows/unit.yml Outdated Show resolved Hide resolved
kevinrizza
kevinrizza previously approved these changes Mar 6, 2024
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes merge queue and other events to skip unit tests.

@bentito could you please double check this?

.github/workflows/unit.yml Outdated Show resolved Hide resolved
Copy link
Member

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm approving, but if you could squash into one commit - that would be great.

This should allow PR comments of the form:
`/retest unit` to trigger `make unit`

Signed-off-by: btofel <btofel@redhat.com>
@bentito bentito force-pushed the add-slash-command-for-make-unit-redo branch from 39d866f to 3bbf6a0 Compare March 13, 2024 14:17
@bentito bentito added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@bentito
Copy link
Contributor Author

bentito commented Mar 13, 2024

e2e (3) seems to fail on a "Subscription when unpacking bundle with bundle which OLM will fail to unpack [It] should report deprecated status when catalog is updated to deprecate an installed bundle"?

Seems unrelated to this PR. Merging again as first check on whether this is a flaky e2e test or something that needs fixing to unblock merges.

@bentito bentito added this pull request to the merge queue Mar 13, 2024
Merged via the queue into master with commit a5035a0 Mar 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants