Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency github actions versions #3225

Closed

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
actions/checkout@v3 -> @v4
actions/setup-go@v4 -> @v5
actions/upload-artifact@v3 -> @V3

Motivation for the change:
Warnings like:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, actions/upload-artifact@v3

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci openshift-ci bot requested review from dinhxuanvu and oceanc80 May 6, 2024 09:47
@itroyano
Copy link

itroyano commented May 6, 2024

Hi @perdasilva,

Adding a .github/dependabot.yml with the following example configuration, should help remove the need for this chore -

version: 2
updates:
  - package-ecosystem: github-actions
    directory: "/"
    schedule:
      interval: "weekly"

in addition the same file can also have dependabot config to take care of go.mod

  - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      interval: "weekly"

@perdasilva
Copy link
Collaborator Author

Ooohhh thank you!!!!

@itroyano
Copy link

itroyano commented May 6, 2024

Note you'll still need to review the PRs opened by Dependabot, but it's very capable of rebasing and doing lots of stuff on its own.

@perdasilva
Copy link
Collaborator Author

closing in favor of #3226

@perdasilva perdasilva closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants