Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/operator-framework/api from v0.23.0 to v0.24.0 #3268

Merged
merged 1 commit into from
May 21, 2024
Merged

build(deps): bump github.com/operator-framework/api from v0.23.0 to v0.24.0 #3268

merged 1 commit into from
May 21, 2024

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 21, 2024 •
edited
Loading

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from anik120 and awgreene May 21, 2024 08:03
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@perdasilva perdasilva mentioned this pull request May 21, 2024
Closed
@perdasilva perdasilva changed the title build(deps): bump github.com/operator-framework/api from v0.23.0 to v… build(deps): bump github.com/operator-framework/api from v0.23.0 to v0.24.0 May 21, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
build(deps): bump github.com/operator-framework/api from v0.23.0 to v…
6a762a7 
…0.24.0

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@grokspawn grokspawn added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@grokspawn grokspawn added this pull request to the merge queue May 21, 2024
Merged via the queue into operator-framework:master with commit 91aaffe May 21, 2024
13 checks passed
@tmshort
Copy link
Contributor

tmshort commented May 22, 2024

@perdasilva did this actually bump operator-framework/api I'm not seeing that in the go.mod diffs...

@perdasilva
Copy link
Collaborator Author

No. It did not. I'm fixing it, but API is broken. Well, fixed now, but needs a new release =S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@anik120 anik120 Awaiting requested review from anik120

@awgreene awgreene Awaiting requested review from awgreene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@perdasilva @tmshort @everettraven @openshift-merge-robot @grokspawn