-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 parameterizes the e2e target and pins opm images #3275
🌱 parameterizes the e2e target and pins opm images #3275
Conversation
9616e7e
to
c0803bf
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
22dc6b9
to
07cf78e
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
07cf78e
to
af279d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me from a code change perspective, but I'm not to familiar with this code base and how effective this change is. If we trust our e2e tests then LGTM :)
unit tests are now failing :( |
Flake (already investing XD - I'll get this repo stable if it kills me!) |
1f5e0dc
Description of the change:
The previous refactored parametrization of the e2e target was too restrictive. This PR re-introduces parameters to configure the e2e test command.
It has also come to our attention that opm:latest images are being used in e2e tests. This PR also pins the opm images to the relevant version of operator-registry
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue