Skip to content

Test NetworkPolicy support in e2es #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test NetworkPolicy support in e2es #3630

wants to merge 3 commits into from

Conversation

oceanc80
Copy link
Contributor

Description of the change:
Now that we've added support for NetworkPolicies, ensure we test that they can be installed correctly.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@trgeiger trgeiger force-pushed the test-np branch 2 times, most recently from 4193fbc to 1baad65 Compare September 3, 2025 19:56
@trgeiger trgeiger changed the title WIP: Test NetworkPolicy support in e2es Test NetworkPolicy support in e2es Sep 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2025
@trgeiger
Copy link

trgeiger commented Sep 4, 2025

Latest revision of the PR adds build files for creating the test bundle image and the test catalog/index image. These are pushed to new tags to keep the old ones if ever needed. I also added a script for rebuilding those images and an addition to the documentation for using the script.

anik120
anik120 previously approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

DEVELOPMENT.md
@@ -46,6 +46,19 @@ To run a specific e2e test locally:
$ make e2e-local TEST=TestCreateInstallPlanManualApproval
```

##### Updating test images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we also give the disclaimer that you need to be logged into quay from an account that has write access to the olmtest namespace?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
anik120
anik120 reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

one discussion to be had

scripts/build_e2e_test_images.sh
@@ -0,0 +1,14 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let's talk about this for a bit. Do we need a new script, or can we add this cleanly to the existing build_test_images.sh script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe what's actually required is proper naming of the two scripts. Right now it's confusing to me what does what if I just read the names. I have to read through the scripts to understand the difference (unnecessary cognitive overload in the workflow).

Maybe

build-update-versioned-index.sh

and

create-single-bundle-index.sh

?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right about combining them, actually. All the images are for different end-to-end tests, so it makes sense to combine them and maybe rename the single script to the name I gave the new one, build_e2e_test_images.sh, to be more descriptive.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I combined them. Let me know if you think that works, or if you think it would be better to separate the 2 index image builds.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@anik120 anik120 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
anik120
anik120 reviewed Sep 4, 2025
View reviewed changes
DEVELOPMENT.md Outdated
Comment on lines 52 to 56

```sh
./scripts/build_test_images.sh
./scripts/build_e2e_test_images.sh
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we are documenting these scripts, might as well write a short summary of what each script does.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@trgeiger
Add single-bundle-index build script
2ecae11 
Adds to script for building the single-bundle-index image used in the e2e tests. Also
adds the necessary manifests and Containerfile for the bundle in that
index, and adds a note in DEVELOPMENT.md about using the script for
updating the images used in e2e tests.

Signed-off-by: Tayler Geiger <tayler@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 anik120 left review comments

@trgeiger trgeiger trgeiger left review comments

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@anik120 anik120

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oceanc80 @trgeiger @anik120