rorfs for cacheless lacks write access to /tmp/ to generate cache #3640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
when we are using
extractContent
, but w/oextractContent.CacheDir
, ensure that we have write permissions to/tmp/
by creating an emptydir volume there.Motivation for the change:
When there is no provided
CacheDir
, our recent changes to setSecurityContext{ReadOnlyFilesystem: ptr.To(true)}
will not allow writing to/tmp/
. However,opm
will need to generate a cache and cannot be told another directory to use.Architectural changes:
Testing remarks:
#3614 passed CI with no errors, both unit which covered ExtractContent functionality including w/o CacheDir.
This is because while the unit tests validated the shape of the resulting pods but not the pods' viability in a cluster (i.e. could the pods walk the initcontainer chain successfully and bring the GRPC service up).
ginkgo test "gRPC address catalog source" does evaluate catsrc pod viability using extractContent, but never as cacheless.
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue