Skip to content

Conversation

@anik120
Copy link
Contributor

@anik120 anik120 commented Oct 29, 2025

Description of the change:

Ignore temp files created in the .claude/ folder

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

.gitignore Outdated

# AI Tools

.claude/
Copy link
Contributor

@tmshort tmshort Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, NICE!!

So then this is an interesting conversation now. The reason I wanted to introduce this gitignore is because I want to create sub-agents at the project level for myself.

When you create a sub-agent at the project level, it's created at .claude/agents/*.md.

However, there's a use case similar to your command sharing use case, where sub-agents can be shared around (so included in git distribution).

I guess the best approach here then is to mimic your changes (ie ignore temporary files), and then explore creating agents we don't want to share at the user level (gets created in the ~/.claude/agents/ folder, ie in the root level).

@anik120 anik120 changed the title gitignore .claude folder gitignore temp files in .claude folder Oct 29, 2025
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented Nov 3, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f10345d into operator-framework:master Nov 3, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants