Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descheduler operator CRD, CSV #584

Conversation

ravisantoshgudimetla
Copy link
Contributor

This PR introduces descheduler crds, csv, package files to be included in rh-operators.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

/test unit

1 similar comment
@ecordell
Copy link
Member

/test unit

- name: MY_POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
Copy link
Member

@ecordell ecordell Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the operator only watches the namespace it runs in, but it requires cluster-wide access to the descheduler kind. Which is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service account we are creating, will be used in descheduler which needs access to node object(which is cluster scoped resource).


## Compatibility matrix

Descheduler | supported Kubernetes version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a NativeAPIs block in the CSV that you can use to list exactly which APIs are required by your operator to exist in kubernetes in order to run, which (in most cases) will let you avoid tracking this type of information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it.

plural: deschedulers
singular: descheduler
scope: Namespaced
version: v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a validation block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them now. Thanks

@ravisantoshgudimetla
Copy link
Contributor Author

@ecordell - I addressed changes suggested. PTAL

@ecordell
Copy link
Member

ecordell commented Dec 5, 2018

/test e2e-aws-olm

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

1 similar comment
@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@ravisantoshgudimetla
Copy link
Contributor Author

@ecordell - The pipeline test seems to be running for a long time. Anything we could do to get this PR moving?

@ecordell
Copy link
Member

ecordell commented Dec 7, 2018

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@ecordell ecordell merged commit c932221 into operator-framework:master Dec 7, 2018
@openshift-ci-robot
Copy link
Collaborator

@ravisantoshgudimetla: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 2f7fae5 link /test unit
ci/prow/e2e-aws-olm 2f7fae5 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ravisantoshgudimetla ravisantoshgudimetla deleted the add-descheduler-crds branch December 7, 2018 18:42
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…dd-descheduler-crds

Descheduler operator CRD, CSV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants