-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descheduler operator CRD, CSV #584
Descheduler operator CRD, CSV #584
Conversation
/test unit |
1 similar comment
/test unit |
- name: MY_POD_NAME | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: metadata.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the operator only watches the namespace it runs in, but it requires cluster-wide access to the descheduler kind. Which is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service account we are creating, will be used in descheduler
which needs access to node object(which is cluster scoped resource).
|
||
## Compatibility matrix | ||
|
||
Descheduler | supported Kubernetes version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a NativeAPIs
block in the CSV that you can use to list exactly which APIs are required by your operator to exist in kubernetes in order to run, which (in most cases) will let you avoid tracking this type of information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into it.
deploy/chart/catalog_resources/rh-operators/descheduler.csv.yaml
Outdated
Show resolved
Hide resolved
plural: deschedulers | ||
singular: descheduler | ||
scope: Namespaced | ||
version: v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a validation block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added them now. Thanks
@ecordell - I addressed changes suggested. PTAL |
451b918
to
9870b11
Compare
/test e2e-aws-olm |
9870b11
to
2f7fae5
Compare
/retest |
1 similar comment
/retest |
@ecordell - The pipeline test seems to be running for a long time. Anything we could do to get this PR moving? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ravisantoshgudimetla: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…dd-descheduler-crds Descheduler operator CRD, CSV
This PR introduces descheduler crds, csv, package files to be included in rh-operators.