bump golang-migrate to v4.16.1 #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 52.35% 52.38% +0.03%
==========================================
Files 107 107
Lines 9688 9688
==========================================
+ Hits 5072 5075 +3
+ Misses 3674 3671 -3
Partials 942 942 |
grokspawn
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
everettraven
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Changes look good to me. A couple things before I add LGTM though:
- Can we remove the
Resolves ...from the PR description? Or at least the "Resolves" part. I don't want it to close the Operator-SDK issue because we still need to update the operator-registry dependency in the operator-sdk go.mod to pull in this change. - Looks like this needs a rebase
Signed-off-by: Jordan <jordan@nimblewidget.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Related to operator-framework/operator-sdk#6450
SDK repo will still have to take action once this is released.
Reviewer Checklist
/docs