-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providing a constraint property constant for dependency consistency #1282
providing a constraint property constant for dependency consistency #1282
Conversation
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, m1kola, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 54.02% 54.02%
=======================================
Files 108 108
Lines 11266 11266
=======================================
Hits 6087 6087
Misses 4190 4190
Partials 989 989 ☔ View full report in Codecov by Sentry. |
bc9a5c2
Description of the change:
add a convenience type for
olm.constraint
family of dependencies for consistent approach to dependency detectionMotivation for the change:
working in pursuit of operator-framework/operator-controller#779 identified that there are not constant types to represent all the dependency types in one place. This should help make operator-framework/operator-controller#781 cleaner.
They are currently divided across
This appears to be for a few reasons:
json.RawMessage
type via the default case since it has no dedicated storage type in this context.Reviewer Checklist
/docs