-
Notifications
You must be signed in to change notification settings - Fork 132
Upgrade helm sample to 0.11.0 version of SDK #78
Upgrade helm sample to 0.11.0 version of SDK #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built it locally, followed the README and it seems to work for me as suggested by the README
@camilamacedo86 now that the helm-operator supports pulling and using a helm-chart from a helm repo, I'd suggest we update this to use the
|
I will check that @joelanford tks. |
helm/README.md
Outdated
This directory contains samples of operators powered by Helm built using the [operator-sdk][operator_sdk]. To learn more about creating an operator that leverages Helm, check out the [Helm user guide][helm_user_guide]. | ||
|
||
[operator_sdk]:https://github.com/coreos/operator-sdk | ||
[helm_user_guide]:https://github.com/operator-framework/operator-sdk/blob/master/doc/helm/user-guide.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we're deleting this? Seems to have some good info and doesn't require someone to navigate all the way into the memcached-operator
sample.
Also, are there any incoming links to this README from any other repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch. it was removed by mistake. back now.
Tks
helm/memcached-operator/README.md
Outdated
``` | ||
# Update the operator manifest to use the built image name (if you are performing these steps on OSX, see note below) | ||
$ sed -i 's|REPLACE_IMAGE|quay.io/example-inc/memcached-operator|g' deploy/operator.yaml | ||
# On OSX use: | ||
$ sed -i "" 's|REPLACE_IMAGE|quay.io/example-inc/memcached-operator|g' deploy/operator.yaml | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting here isn't great. I'd suggest this:
Update the operator manifest to use the built image name (if you are performing these steps on OSX, see note below)
```sh
$ sed -i 's|REPLACE_IMAGE|quay.io/example/memcached-operator|g' deploy/operator.yaml
```
**Note**
If you are performing these steps on OSX, use the following `sed` command instead:
```sh
$ sed -i "" 's|REPLACE_IMAGE|quay.io/example/memcached-operator|g' deploy/operator.yaml
```
helm/memcached-operator/README.md
Outdated
|
||
Run `make install` to install the operator. Check that the operator is running in the cluster, also check that the example Memcached service was deployed. | ||
|
||
Following the expected result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the expected result. | |
Run the following commands to verify that the installation was successful: |
helm/memcached-operator/README.md
Outdated
|
||
### Uninstalling | ||
|
||
To uninstall all that was performed in the above step run `make uninstall`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To uninstall all that was performed in the above step run `make uninstall`. | |
To uninstall all that was performed in the above step, run `make uninstall`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced the order to be easier the understanding and solve this issue 👍
HI @joelanford, Thank you for the review. All requests are done. Also, I retest it locally as follows. Feel free to use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description