pkg/scaffold/cmd.go: Skip erroring out on Service

If the Service could not be created we just log the error instead of
erroring out and exiting. This error could occur when there is more than
one pods such as with leader election. In that case the new pod will
expose the metrics via the already created Service object.

pkg/scaffold/cmd.go

@@ -51,6 +51,7 @@ import (
 	"github.com/operator-framework/operator-sdk/pkg/metrics"
 	"github.com/operator-framework/operator-sdk/pkg/ready"
 	sdkVersion "github.com/operator-framework/operator-sdk/version"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
@@ -131,7 +132,7 @@ func main() {
 		os.Exit(1)
 	}
 	client := mgr.GetClient()
-	if err := client.Create(context.TODO(), s); err != nil {
+	if err := client.Create(context.TODO(), s); err != nil && !apierrors.IsAlreadyExists(err) {
 		log.Error(err, "")
 		os.Exit(1)
 	}

pkg/scaffold/cmd_test.go

@@ -49,6 +49,7 @@ import (
 	"github.com/operator-framework/operator-sdk/pkg/metrics"
 	"github.com/operator-framework/operator-sdk/pkg/ready"
 	sdkVersion "github.com/operator-framework/operator-sdk/version"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
@@ -129,7 +130,7 @@ func main() {
 		os.Exit(1)
 	}
 	client := mgr.GetClient()
-	if err := client.Create(context.TODO(), s); err != nil {
+	if err := client.Create(context.TODO(), s); err != nil && !apierrors.IsAlreadyExists(err) {
 		log.Error(err, "")
 		os.Exit(1)
 	}