Skip to content

Commit

Permalink
revert defaulter-gen
Browse files Browse the repository at this point in the history
removes defaulter gen, instead users should use mutating webhooks

reverts pr #1050
  • Loading branch information
theishshah committed Apr 4, 2019
1 parent c15e6a6 commit b5af8b2
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions cmd/operator-sdk/internal/genutil/k8s.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ func K8sCodegen(hf string) error {
binDir := filepath.Join(wd, scaffold.BuildBinDir)

genDirs := []string{
"./cmd/defaulter-gen",
"./cmd/client-gen",
"./cmd/lister-gen",
"./cmd/informer-gen",
Expand All @@ -63,10 +62,6 @@ func K8sCodegen(hf string) error {
if err = withHeaderFile(hf, fdc); err != nil {
return err
}
fd := func(a string) error { return defaulterGen(binDir, repoPkg, a, gvMap) }
if err = withHeaderFile(hf, fd); err != nil {
return err
}

log.Info("Code-generation complete.")
return nil
Expand All @@ -88,19 +83,3 @@ func deepcopyGen(binDir, repoPkg, hf string, gvMap map[string][]string) (err err
}
return nil
}

func defaulterGen(binDir, repoPkg, hf string, gvMap map[string][]string) (err error) {
apisPkg := filepath.Join(repoPkg, scaffold.ApisDir)
args := []string{
"--input-dirs", createFQApis(apisPkg, gvMap),
"--output-file-base", "zz_generated.defaults",
// defaulter-gen requires a boilerplate file. Either use header or an
// empty file if header is empty.
"--go-header-file", hf,
}
cmd := exec.Command(filepath.Join(binDir, "defaulter-gen"), args...)
if err = projutil.ExecCmd(cmd); err != nil {
return fmt.Errorf("failed to perform defaulter code-generation: %v", err)
}
return nil
}

0 comments on commit b5af8b2

Please sign in to comment.