Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: trim gopath from panic logs (#1042) #1043

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Trim the GOPATH from binaries built with install or build.

Motivation for the change: Remove the home directory of the builder from the panic path.

**Description of the change:** Trim the GOPATH from binaries built with `install` or `build`.

**Motivation for the change:** Remove the home directory of the builder from the panic path.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 1, 2019
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with these changes but we should simplify them by using GOFLAGS when we switch to go 1.11.

EDIT: Apologies I just noticed this is a cherry pick. LGTM.

@AlexNPavel AlexNPavel merged commit 37d4faa into operator-framework:v0.4.x Feb 1, 2019
@AlexNPavel AlexNPavel deleted the cherrypick-1042 branch February 1, 2019 23:46
shawn-hurley pushed a commit to shawn-hurley/operator-sdk that referenced this pull request Apr 23, 2019
…ator-framework#1043)

**Description of the change:** Trim the GOPATH from binaries built with `install` or `build`.

**Motivation for the change:** Remove the home directory of the builder from the panic path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants