-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ansible/controller: Updater api reader to use client #1054
Merged
shawn-hurley
merged 1 commit into
operator-framework:v0.4.x
from
shawn-hurley:bugfix/ci-testing
Feb 4, 2019
Merged
pkg/ansible/controller: Updater api reader to use client #1054
shawn-hurley
merged 1 commit into
operator-framework:v0.4.x
from
shawn-hurley:bugfix/ci-testing
Feb 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
added
kind/bug
Categorizes issue or PR as related to a bug.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
language/ansible
Issue is related to an Ansible operator project
labels
Feb 4, 2019
openshift-ci-robot
added
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Feb 4, 2019
openshift-ci-robot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Feb 4, 2019
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
February 4, 2019 13:03
0f8245c
to
ef61bba
Compare
openshift-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Feb 4, 2019
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
February 4, 2019 17:30
a688bc2
to
084b0a2
Compare
shawn-hurley
changed the title
[WIP] - pkg/ansible: fix CI
pkg/ansible/controller: Updater api reader to use client
Feb 4, 2019
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Feb 4, 2019
fabianvf
reviewed
Feb 4, 2019
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
February 4, 2019 18:58
084b0a2
to
13cc9b5
Compare
* Handle case when CR is changed while we are working on it. To handle this we will return and just re-run the reconcile this should be fine due to eventually consistent model.
shawn-hurley
force-pushed
the
bugfix/ci-testing
branch
from
February 4, 2019 19:01
13cc9b5
to
1e0a343
Compare
fabianvf
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
…mework#1054) * Handle case when CR is changed while we are working on it. To handle this we will return and just re-run the reconcile this should be fine due to eventually consistent model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
language/ansible
Issue is related to an Ansible operator project
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use the API reader to get the object from API after ansible has run.
Also, to deal with changes that a user could have made during the reconciliation run, we will just requeue the object and handle. This conforms to the eventually consistent model.
Motivation for the change:
To change the case when a resource is updated by the user as we are reconciling. This means that we will stop what we are doing and requeue the update.