README.md: update kubernetes prereq to 1.11.3+ #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
requested review from
lilic,
estroz and
hasbro17
and removed request for
hasbro17 and
estroz
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
@jmrodri: changing LGTM is restricted to assignees, and only operator-framework/operator-sdk repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update Kubernetes prerequisite from 1.11.0+ to 1.11.3+
Motivation for the change:
Kubernetes 1.11.3 has fixes for CRD pluralization. We noticed this with the Helm e2e test, which uses "Nginx" as the CRD name. "Nginx" is a name that triggers the CRD pluralization bug prior to 1.11.3.
This version prerequisite is likely applicable to the ansible operator as well, since it uses the same mechanism as the helm operator to watch CRs. I'm not sure if this would also impact go-based operators.
Also, the OKD docs already list 1.11.3+ as the prereq: https://docs.okd.io/latest/operators/osdk-getting-started.html#installing-operator-sdk-cli_osdk-getting-started