-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: update kubernetes prereq to 1.11.3+ #1166
README.md: update kubernetes prereq to 1.11.3+ #1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
@jmrodri: changing LGTM is restricted to assignees, and only operator-framework/operator-sdk repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of the change:
Update Kubernetes prerequisite from 1.11.0+ to 1.11.3+
Motivation for the change:
Kubernetes 1.11.3 has fixes for CRD pluralization. We noticed this with the Helm e2e test, which uses "Nginx" as the CRD name. "Nginx" is a name that triggers the CRD pluralization bug prior to 1.11.3.
This version prerequisite is likely applicable to the ansible operator as well, since it uses the same mechanism as the helm operator to watch CRs. I'm not sure if this would also impact go-based operators.
Also, the OKD docs already list 1.11.3+ as the prereq: https://docs.okd.io/latest/operators/osdk-getting-started.html#installing-operator-sdk-cli_osdk-getting-started