pkg/helm/controller/reconcile.go: fix conditions logic #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a change is made to the CR spec that causes a release failure, a ConditionReleaseFailed is added to the status conditions. If that change is then reverted to its previous state, the operator will stop attempting the release and will resume reconciling. In this case, we need to remove the ConditionReleaseFailed because the failing release is no longer being attempted.
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
size/S
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 2, 2019
…ework#1321) * pkg/helm/controller/reconcile.go: fix conditions logic If a change is made to the CR spec that causes a release failure, a ConditionReleaseFailed is added to the status conditions. If that change is then reverted to its previous state, the operator will stop attempting the release and will resume reconciling. In this case, we need to remove the ConditionReleaseFailed because the failing release is no longer being attempted. * CHANGELOG.md: add bug fix operator-framework#1321
joelanford
added a commit
that referenced
this pull request
May 2, 2019
…) (#1370) * pkg/helm/controller/reconcile.go: fix conditions logic If a change is made to the CR spec that causes a release failure, a ConditionReleaseFailed is added to the status conditions. If that change is then reverted to its previous state, the operator will stop attempting the release and will resume reconciling. In this case, we need to remove the ConditionReleaseFailed because the failing release is no longer being attempted. * CHANGELOG.md: add bug fix #1321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Remove
ReleaseFailedcondition when reconciling an existing deployed release.Motivation for the change:
If a change is made to the CR spec that causes a release failure, a
ReleaseFailedcondition is added to the status conditions. If that change is then reverted to its previous state, the operator will stop attempting the release and will resume reconciling.In this case, we need to remove the
ReleaseFailedcondition because the failing release is no longer being attempted.