cmd,pkg/test,test/e2e: remove test cluster subcommand
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
lilic
suggested changes
May 14, 2019
|
@AlexNPavel do we also need to remove the build with test flag? |
AlexNPavel
force-pushed
the
remove-test-cluster
branch
from
ba6e374 to
780d7a4
Compare
|
I've updated the docs. PTAL. /cc @lilic @shawn-hurley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: Remove the
test clustersubcommandMotivation for the change: There haven't been any mentions of this in issues and it does not seem that anybody is actually using this testing mode. It requires a lot of extra code to support and is very prone to breaking. Removing it will reduce the size of our codebase, the amount of maintenance we may need to support this long term, and potential issues in the future.