Breaking change: bumping kube-state-metrics to v1.7.2 #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Sep 19, 2019
…rics version bump)
openshift-ci-robot
added
size/L
|
/test e2e-aws-ansible |
|
Hi @joelanford, Shows that after the change has not been possible to build the osdk-ansible-e2e-hybrid docker image. I think is the file https://github.com/operator-framework/operator-sdk/blob/master/ci/dockerfiles/ansible-e2e-hybrid.Dockerfile. Maybe try to build manually to check. Just an idea. |
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Oct 2, 2019
…rics version bump)
openshift-ci-robot
added
needs-rebase
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
Oct 2, 2019
…rics version bump)
openshift-ci-robot
removed
the
needs-rebase
hasbro17
reviewed
Oct 3, 2019
hasbro17
reviewed
Oct 3, 2019
openshift-ci-robot
added
the
needs-rebase
…rics version bump)
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
openshift-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
kubemetrics.NewCollectorsand replaces it withkubemetrics.NewMetricsStores, and updates other exported function signatures to handle upstream breaking change. See Remove collector package kubernetes/kube-state-metrics#786Motivation for the change:
There is a breaking change in kube-state-metrics 1.7.x and we are currently at 1.6.0. It would be nice to get this change in to the next release since there are already breaking changes on
mastersince our last release.There also seems to be an issue with ksm < v1.7.x with go1.13, so this may be required to upgrade to go1.13. See #1925