Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2023: jmespath required to run default molecule tests in Travis CI environment. #2027

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fixes #2023: jmespath required to run default molecule tests in Travis CI environment. #2027

merged 1 commit into from
Oct 9, 2019

Conversation

geerlingguy
Copy link
Contributor

Description of the change:
Add missing jmespath dependency to .travis.yml template for Ansible-based operators.

Motivation for the change:

Closes #2023

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2019
@openshift-ci-robot
Copy link

Hi @geerlingguy. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2019
@geerlingguy geerlingguy mentioned this pull request Oct 9, 2019
Closed
@camilamacedo86
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2019
camilamacedo86
camilamacedo86 reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great. It is just missing a fixed entry in the CHNAGELOG. Could you please add it?

@geerlingguy
Copy link
Contributor Author

@camilamacedo86 - Changelog entry has been added! Thanks.

camilamacedo86
camilamacedo86 reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes show ok. I am testing it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@camilamacedo86
Copy link
Contributor

/test e2e-aws-subcommand

@camilamacedo86 camilamacedo86 removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@camilamacedo86
Copy link
Contributor

/test e2e-aws-subcommand

@camilamacedo86
Copy link
Contributor

/test e2e-aws-ansible

@fabianvf
Copy link
Member

fabianvf commented Oct 9, 2019

/lgtm
I bet we can remove this dependency entirely with ansible 2.8+, I think the jmespath stuff was just because parsing conditions is so hard, but now that we have wait and wait_condition we should be able to drop it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@camilamacedo86 camilamacedo86 added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 9, 2019
camilamacedo86
camilamacedo86 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could confirm that the error reported in #2023 is no longer faced with this PR.

@geerlingguy
Copy link
Contributor Author

@fabianvf - It seems like the Ansible core team is also solidly against ever depending on jmespath for anything, as they've repeatedly closed requests to have it added. Since it's only used by a few modules that are not 'core supported' it would be nice to not have to have it if it's not absolutely necessary.

@camilamacedo86
Copy link
Contributor

/test e2e-aws-subcommand
/test e2e-aws-ansible
/test e2e-aws-helm
/test e2e-aws-go

@camilamacedo86
Copy link
Contributor

/test e2e-aws-go
/test e2e-aws-helm

@camilamacedo86
Copy link
Contributor

/test e2e-aws-subcommand
/test e2e-aws-ansible
/test e2e-aws-go
/test e2e-aws-helm

jmrodri
jmrodri approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86
Copy link
Contributor

/test e2e-aws-subcommand
/test e2e-aws-ansible
/test e2e-aws-go
/test e2e-aws-helm

@camilamacedo86 camilamacedo86 merged commit fd528e8 into operator-framework:master Oct 9, 2019
@camilamacedo86
Copy link
Contributor

Hi @fabianvf,

Should we address anything else regards your comment?

I bet we can remove this dependency entirely with ansible 2.8+, I think the jmespath stuff was just because parsing conditions is so hard, but now that we have wait and wait_condition we should be able to drop it.

Should we track it?

@camilamacedo86 camilamacedo86 mentioned this pull request Oct 9, 2019
Merged
@hasbro17 hasbro17 mentioned this pull request Oct 10, 2019
Merged
fabianvf pushed a commit to fabianvf/operator-sdk that referenced this pull request Oct 14, 2019
@geerlingguy @fabianvf
Fixes operator-framework#2023: jmespath required to run default molec…
a2b872d 
…ule tests in Travis CI environment. (operator-framework#2027)
@camilamacedo86 camilamacedo86 mentioned this pull request Nov 19, 2019
Closed
@geerlingguy geerlingguy mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri jmrodri approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@jmrodri jmrodri

@fabianvf fabianvf

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default ansible operator Travisfile doesn't work - jmespath error
5 participants
@geerlingguy @openshift-ci-robot @camilamacedo86 @fabianvf @jmrodri