Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add metrics test for memcached helm-based operator #2092

Closed
wants to merge 3 commits into from
Closed

WIP: add metrics test for memcached helm-based operator #2092

wants to merge 3 commits into from

Conversation

camilamacedo86
Copy link
Contributor

Description of the change:

Motivation for the change:

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2019
@openshift-ci-robot
Copy link

@camilamacedo86: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-go e200606 link /test e2e-aws-go
ci/prow/e2e-aws-subcommand e200606 link /test e2e-aws-subcommand
ci/prow/e2e-aws-helm e200606 link /test e2e-aws-helm
ci/prow/e2e-aws-ansible e200606 link /test e2e-aws-ansible

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

@camilamacedo86 I don't think we need another e2e just to cover the role change. In #2090, you have the code fix and the unit test update, which is a much faster and more reliable test, and provides coverage for what this test is meant to cover.

@camilamacedo86
Copy link
Contributor Author

Thank you @joelanford I am closing this one so.

@camilamacedo86 camilamacedo86 deleted the helm-test-fix branch October 23, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz Awaiting requested review from estroz

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @openshift-ci-robot @joelanford