operator-migrate: migrate an existing SDK project to a kubebuilder-style one #2851
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/kb-migrate
branch
6 times, most recently
from
74d9dc6 to
8f573b0
Compare
estroz
added
the
kubebuilder-integration
estroz
changed the title
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&c.ptype, "type", "", |
There was a problem hiding this comment.
I think the tool would just make sense for GO operators, so would be required to have a type here?
| "directory of project to migrate") | ||
| cmd.Flags().StringVar(&c.toDir, "to-dir", "", | ||
| "directory to place migrated project") | ||
|
|
There was a problem hiding this comment.
WDYT about source and tagert instead of from-dir to "to-dir"?
| if len(pathSplit) < 2 || filePath == "go.mod" || filePath == "go.sum" { | ||
| return filePath | ||
| } | ||
|
|
There was a problem hiding this comment.
| dir := pathSplit[0] |
| } | ||
|
|
||
| switch { | ||
| case pathSplit[0] == "deploy": |
There was a problem hiding this comment.
| case pathSplit[0] == "deploy": | |
| case dir == "deploy": |
|
|
||
| func main() { | ||
| if err := rootCmd().Execute(); err != nil { | ||
| os.Exit(1) |
There was a problem hiding this comment.
should not log the error?
openshift-ci-robot
added
the
needs-rebase
estroz
force-pushed
the
feature/kb-migrate
branch
from
8f573b0 to
7581fa2
Compare
openshift-ci-robot
removed
the
needs-rebase
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/kb-migrate
branch
from
7581fa2 to
c5d6cff
Compare
openshift-ci-robot
added
the
needs-rebase
estroz
force-pushed
the
feature/kb-migrate
branch
from
c5d6cff to
0e64051
Compare
openshift-ci-robot
removed
the
needs-rebase
| @@ -0,0 +1,131 @@ | |||
| // Copyright 2020 The Operator-SDK Authors | |||
There was a problem hiding this comment.
WDYT about it be an incubete/tools module whcih will allow users to get it such as go get github.com/operator-framework/operator-sdk/incubete/tools/migration. Then, we also can publish it without support and getting started to give an opportunity to receive an incubating project for the https://github.com/operator-framework/community/pull/22/files which would allow us to move forward with #3787. We might be able to have as well go get github.com/operator-framework/operator-sdk/incubete/plugins.
Description of the change:
operator-migratemigrates an operator-sdk-style project to a kubebuilder-style project.Motivation for the change: eases the migration process to a kubebuilder-style project:
This will run
operator-sdk initthenoperator-sdk create apifor each API type found indeploy/crds.TODO's: