Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,hack: add e2e test for new project layout #3060

Merged
merged 2 commits into from
May 28, 2020
Merged

test,hack: add e2e test for new project layout #3060

merged 2 commits into from
May 28, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented May 16, 2020 •
edited
Loading

Description of the change:

  • test/e2e-new: test suite and utils for running a simple e2e test on a project with the new layout (operator-sdk init'd)
  • hack/tests/e2e-go-new.sh: run new project layout test suite
  • .travis.yml: add new job
  • Makefile: add test-e2e-go-new to run the test suite

Motivation for the change: we need a simple e2e test that ensures changes made to the underlying kubebuilder plugin result in a valid operator, without duplicating much code from upstream e2e tests.

Note: once kubernetes-sigs/kubebuilder#1520 is merged, /test/e2e-new/util can be removed.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2020
@estroz estroz force-pushed the chore/new-e2e-tests branch 4 times, most recently from 5782d11 to d6c5115 Compare May 19, 2020 05:59
@estroz estroz force-pushed the chore/new-e2e-tests branch 4 times, most recently from 15a20e4 to a1c9fb9 Compare May 26, 2020 17:36
@estroz estroz marked this pull request as ready for review May 26, 2020 17:36
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2020
@estroz
Copy link
Member Author

estroz commented May 26, 2020

/cc @hasbro17 @jmrodri @jmccormick2001

@estroz estroz requested a review from camilamacedo86 May 26, 2020 17:37
@estroz estroz force-pushed the chore/new-e2e-tests branch 2 times, most recently from 884ad21 to 96e249d Compare May 26, 2020 18:56
hasbro17
hasbro17 reviewed May 26, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@estroz estroz force-pushed the chore/new-e2e-tests branch 2 times, most recently from dd95359 to a7a0af9 Compare May 27, 2020 00:34
@estroz estroz requested review from hasbro17 and camilamacedo86 May 27, 2020 01:08
@camilamacedo86 camilamacedo86 self-requested a review May 27, 2020 01:11
camilamacedo86
camilamacedo86 approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

It shows great for me 👍
It is doing the test and we can improve it according to our needs.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
hasbro17
hasbro17 reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much LGTM except we probably want to make it explicitly clear in the script that we're not using envtest right now.

hack/lib/common.sh Outdated Show resolved Hide resolved
hack/tests/e2e-go-new.sh Show resolved Hide resolved
hasbro17
hasbro17 approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a comment on why we're setting up envtest vars.

@estroz estroz force-pushed the chore/new-e2e-tests branch from a7a0af9 to ccd6cf9 Compare May 28, 2020 01:23
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@estroz estroz force-pushed the chore/new-e2e-tests branch from ccd6cf9 to 0a02611 Compare May 28, 2020 01:44
@estroz estroz merged commit 013896a into operator-framework:master May 28, 2020
@estroz estroz deleted the chore/new-e2e-tests branch May 28, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@camilamacedo86 camilamacedo86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estroz @openshift-ci-robot @hasbro17 @camilamacedo86