-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg/ready #3476
Remove pkg/ready #3476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are no longer used by default. However, are still they valid/useful with the new layout? Would we really like to no longer support it? If yes, we need to add a fragment with the info for the migration guide since it is a significant breaking change. See that it has been used: https://github.com/search?q=operator-sdk%2Fpkg%2Fready&type=Code
@camilamacedo86 Per our pervious discussions we decided the readiness probe helpers would be removed in And for users who still want it, the helpers are only a few lines of writing/reading a file on disk. Should be easy enough to replicate. And yes I have a TODO for the fragment which I'll add shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing fragment. Otherwise, shows ok.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just for reference, we removed usage of the ready package from the Go scaffold all the way back in Also |
Description of the change:
Remove the readiness probe helpers in
pkg/ready
.Motivation for the change:
With the new scaffolds the readiness probe helpers in
pkg/ready
are no longer used by default, and need to be removed from the main CLI repo for thev1.0.0
release.Related to #3327
TODO