Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: move pkg/ansible to internal/ansible #3560

Merged
merged 1 commit into from
Jul 27, 2020
Merged

*: move pkg/ansible to internal/ansible #3560

merged 1 commit into from
Jul 27, 2020

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Jul 27, 2020 •
edited
Loading

Description of the change:
Move pkg/ansible to internal/ansible

Motivation for the change:
There should be no exported APIs in Operator SDK 1.0.0

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@joelanford joelanford force-pushed the mv-ansible-internal branch from 2040a43 to bf550ac Compare July 27, 2020 13:51
jmrodri
jmrodri approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source tree looks great now. I was able to build the ansible-operator executable with no issues.

@jmrodri
Copy link
Member

jmrodri commented Jul 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@joelanford joelanford merged commit 55f1b84 into operator-framework:master Jul 27, 2020
@joelanford joelanford deleted the mv-ansible-internal branch July 27, 2020 14:43
@joelanford joelanford mentioned this pull request Jul 27, 2020
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@estroz estroz Awaiting requested review from estroz

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@jmrodri jmrodri

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelanford @jmrodri @openshift-ci-robot