Use bash with source #4761
Closed
Use bash with source #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaardie
force-pushed
the
bash-for-source
branch
from
b20da2f to
95e8787
Compare
jmrodri
reviewed
Apr 15, 2021
| @@ -13,7 +13,7 @@ ENVTEST_ASSETS_DIR=$(shell pwd)/testbin | |||
| test: manifests generate fmt vet | |||
| mkdir -p ${ENVTEST_ASSETS_DIR} | |||
| test -f ${ENVTEST_ASSETS_DIR}/setup-envtest.sh || curl -sSLo ${ENVTEST_ASSETS_DIR}/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/master/hack/setup-envtest.sh | |||
| source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out | |||
| base -c "source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out" | |||
There was a problem hiding this comment.
Suggested change
| base -c "source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out" | |
| bash -c "source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out" |
|
@varshaprasad96 could you verify this change also works on a Mac? |
This patch calls the commands with `source` with the bash directly. This way these commands also work on OS like Debian where `/bin/sh` is actually not the bash, but another maybe not compatitible shell like `dash`. Signed-off-by: Sven Haardiek <sven@haardiek.de>
shaardie
force-pushed
the
bash-for-source
branch
from
95e8787 to
1c5b687
Compare
|
This will be fixed by kubernetes-sigs/kubebuilder#2149 upstream then pulled into operator-sdk. If the fix is not accepted upstream, I'd like to port those changes here. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This patch calls the commands with
sourcewith the bash directly.Motivation for the change:
This way these commands also work on OS like Debian where
/bin/shis actuallynot the bash, but another maybe not compatitible shell like
dash.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs