Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link to the envtest documentation in the v1.0.0 migration guide #5100

Conversation

timflannagan
Copy link
Member

Update the v1.0.0.md migration guide and ensure the link to the envtest
documentation is correctly formatted.

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from asmacdo and joelanford July 29, 2021 22:44
…migration guide

Update the v1.0.0.md migration guide and ensure the link to the envtest
documentation is correctly formatted.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan force-pushed the fix-broken-link-v1.0.0-migration-guide branch from 2afc4b1 to 2361280 Compare July 29, 2021 22:44
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan force-pushed the fix-broken-link-v1.0.0-migration-guide branch from a36c8f5 to 2fc0ed7 Compare July 29, 2021 22:54
@timflannagan
Copy link
Member Author

That looks like it can be ignored:

  *  External link https://v1-10-x.sdk.operatorframework.io/ failed: response code 0 means something's wrong.
             It's possible libcurl couldn't connect to the server or perhaps the request timed out.
             Sometimes, making too many requests at once also breaks things.
             Either way, the return message (if any) from the server is: Couldn't resolve host name

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2021
@estroz estroz changed the title website/content: Fix link to the envtest documentation in the v1.0.0 migration guide docs: Fix link to the envtest documentation in the v1.0.0 migration guide Aug 2, 2021
@estroz estroz merged commit 820764f into operator-framework:master Aug 2, 2021
@timflannagan timflannagan deleted the fix-broken-link-v1.0.0-migration-guide branch August 2, 2021 22:28
@estroz
Copy link
Member

estroz commented Aug 3, 2021

/cherry-pick v1.8.x

@estroz
Copy link
Member

estroz commented Aug 3, 2021

/cherry-pick v1.9.x

@estroz
Copy link
Member

estroz commented Aug 3, 2021

/cherry-pick v1.10.x

@openshift-cherrypick-robot

@estroz: new pull request created: #5109

In response to this:

/cherry-pick v1.8.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@estroz: new pull request created: #5110

In response to this:

/cherry-pick v1.9.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@estroz: new pull request created: #5111

In response to this:

/cherry-pick v1.10.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz pushed a commit that referenced this pull request Aug 3, 2021
…gration guide (#5109)

This is an automated cherry-pick of #5100

Co-authored-by: timflannagan <timflannagan@gmail.com>
estroz pushed a commit that referenced this pull request Aug 3, 2021
…gration guide (#5110)

This is an automated cherry-pick of #5100

Co-authored-by: timflannagan <timflannagan@gmail.com>
estroz pushed a commit that referenced this pull request Aug 3, 2021
…igration guide (#5111)

This is an automated cherry-pick of #5100

Co-authored-by: timflannagan <timflannagan@gmail.com>
bentito pushed a commit to bentito/operator-sdk that referenced this pull request Aug 24, 2021
…uide (operator-framework#5100)

* Update the v1.0.0.md migration guide and ensure the link to the envtest
documentation is correctly formatted.
* Fix broken scorecard link

Signed-off-by: timflannagan <timflannagan@gmail.com>
twasyl pushed a commit to twasyl/operator-sdk that referenced this pull request Sep 3, 2021
…uide (operator-framework#5100)

* Update the v1.0.0.md migration guide and ensure the link to the envtest
documentation is correctly formatted.
* Fix broken scorecard link

Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: Thierry Wasylczenko <thierry.wasylczenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants