Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator-framework api to 0.10.5 #5119

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

kevinrizza
Copy link
Member

Update the vendored api ref to the latest z to pull in new validation changes

Related pr: operator-framework/api#144

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think vendored directory is needed though

@kevinrizza
Copy link
Member Author

I don't think vendored directory is needed though

Ah, didn't realize the project didn't include the vendor dir. I just updated the pr to just modify the mod and sum files

@estroz
Copy link
Member

estroz commented Aug 4, 2021

Fixed the bug causing the new validation to fail: #5120

@asmacdo
Copy link
Member

asmacdo commented Aug 5, 2021

@estroz do we include changelog entries for library bumps?

@estroz
Copy link
Member

estroz commented Aug 5, 2021

@asmacdo not directly. It's a good idea to make one for the new validation though.

@kevinrizza
Copy link
Member Author

Closing and reopening to retrigger tests

Signed-off-by: kevinrizza <krizza@redhat.com>
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2021
@estroz estroz merged commit e5a0ebb into operator-framework:master Aug 9, 2021
bentito pushed a commit to bentito/operator-sdk that referenced this pull request Aug 24, 2021
Signed-off-by: kevinrizza <krizza@redhat.com>
twasyl pushed a commit to twasyl/operator-sdk that referenced this pull request Sep 3, 2021
Signed-off-by: kevinrizza <krizza@redhat.com>
Signed-off-by: Thierry Wasylczenko <thierry.wasylczenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants