-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design doc csv generation #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions
f6d226f
to
90a765b
Compare
This looks great! |
b7f1f73
to
a2eb129
Compare
e0d18d6
to
6f3918f
Compare
This looks great, can't wait to try it out 😄 Should we talk about additional management features here, or should they go in another proposal? One concern of mine is helping sdk users understand how to build sets of updates, not just a single CSV. This would be dealing with channels, packages, |
@ecordell yeah that stuff should go in another proposal. This one is mostly for how CSV's will be generated from input data. |
e842ce4
to
8850ab3
Compare
I am having a pretty difficult time following the proposal, and because of this, I am worried that I might be missing gaps in regards to the ansible operator. Sorry for not getting it. Two things I notice even without following:
What I might be proposing here is a different directory with different rules that might be bootstrapped from deploy but allows us to keep the deploy scripts "here run x and now your working" while another directory can start to remove stuff to take advantage of OLM offerings. Maybe this is starting to think about the "next level" stuff that Evan mentions. It might be nice to help me understand if you add an expected user workflow section? with the different use cases, we are solving and what you expect the commands to be and what the output of each would be? |
Points from our discussion of @shawn-hurley's comment out-of-band:
I'm going to add more notes on CSV generation/usage workflow, as well as a flow diagram. |
e60bc71
to
9e88920
Compare
Overall SGTM. Just need to clarify the nit on how the generator knows the CSV version while generating it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits and questions, but overall sounds sane to me :)
b8e4d33
to
6c734b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would like to see the answer to which command this will be apart of.
I will say that this does appear to be adding much more complexity to the build command, which will get more complex once we get the manage dockerfiles stuff completed. I think we may want to keep that in mind.
d149430
to
8cf96df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is good enough for the proposal.
Once we start iterating on the actual implementation we'll see how we can revisit the TODO's for managing multiple CSV versions.
This PR contains a first stab at a design doc describing SDK generation of ClusterServiceVersion's (CSV's) for operators. Mechanisms and conventions described in this draft are suggestions, not necessarily features.
Check out #673 for a WIP implementation.