Adding sort to reorder webhookDescription based on webhookType #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sujil02 <sujil.shah@gmail.com>
Signed-off-by: sujil02 <sujil.shah@gmail.com>
camilamacedo86
suggested changes
Aug 28, 2021
There was a problem hiding this comment.
Hi @sujil02,
For we are able to merge your contribution you need to:
- Add changelog entry to generate the release notes.
- Run make generate that will re-gen the docs and the samples in the testdata.
Done. |
| by sorting `webhookDescriptions` in CSV generator. | ||
|
|
||
| kind: bugfix | ||
| breaking: false |
Signed-off-by: sujil02 <sujil.shah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding sort to reorder webhookDescription based on webhookType
https://issues.redhat.com/browse/OSDK-1916
#5022
Signed-off-by: sujil02 sujil.shah@gmail.com
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs