Add support for external bundle validators #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jmrodri
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ryantking
reviewed
Feb 17, 2022
jmrodri
commented
Mar 30, 2022
jmrodri
force-pushed
the
validator-update
branch
from
872c49e to
d597916
Compare
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
jmrodri
force-pushed
the
validator-update
branch
2 times, most recently
from
51d627b to
e7d71cc
Compare
The PrintWithFormat method would hard exit if there was an error in the test. Instead of returning a special error for this case, we added a boolean to indicate if there is a failed result. This allows the cmd to handle this case and we no longer have a hard exit in the middle of a library function. Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
jmrodri
force-pushed
the
validator-update
branch
from
e7d71cc to
89cd7e3
Compare
everettraven
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding support for external bundle validators.
Motivation for the change:
Today whenever there are validation changes specific to OpenShift, that often trickles to the upstream release. By adding external bundle validator support, this can allow bundle validator authors to create external binaries to be called by operator-sdk and allow business specific validators to not impact upstream releases.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs