🐛 fix operator-sdk generate kustomize manifests to respect changes made by users in the config/manifests #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de by users in the config/manifests Signed-off-by: Camila Macedo <cmacedo@redhat.com>
everettraven
requested changes
Aug 1, 2022
Co-authored-by: Bryce Palmer <everettraven@gmail.com>
Co-authored-by: Bryce Palmer <everettraven@gmail.com>
dacamposol
pushed a commit
to dacamposol/operator-sdk
that referenced
this pull request
Oct 6, 2022
…de by users in the config/manifests (operator-framework#5960) * 🐛 fix operator-sdk generate kustomize manifests to respect changes made by users in the config/manifests Signed-off-by: Camila Macedo <cmacedo@redhat.com> * Update website/content/en/docs/faqs/_index.md Co-authored-by: Bryce Palmer <everettraven@gmail.com> * Update website/content/en/docs/faqs/_index.md Co-authored-by: Bryce Palmer <everettraven@gmail.com> Co-authored-by: Bryce Palmer <everettraven@gmail.com> Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Camila Macedo cmacedo@redhat.com
Description of the change:
fix operator-sdk generate kustomize manifests to respect changes made by users in the config/manifests
Motivation for the change:
If we change the target value on the command to solve the breaking change faced with Kustomize v4 it still not working
because the SDK subcommand call the Helper plugin to generate the CSV and it was not configured to Skip the file when it is scaffolded already.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsMotivation: #5898