Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix): bump operator-framework/api dependency version #6227

Merged

Conversation

everettraven
Copy link
Contributor

Description of the change:

Motivation for the change:

  • Fixes a bug in the k8s 1.25 validation logic when running operator-sdk bundle validate ... that was caused by the validation logic not checking both the group and the resource when validating permissions in the CSV. This bug would cause a warning to be issued to all resources with the same name regardless of what group they are in.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci openshift-ci bot requested review from fabianvf and jmrodri December 22, 2022 15:25
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@oceanc80
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@everettraven everettraven merged commit ad9447b into operator-framework:master Dec 22, 2022
@everettraven
Copy link
Contributor Author

/cherry-pick v1.26.x

@openshift-cherrypick-robot

@everettraven: new pull request created: #6231

In response to this:

/cherry-pick v1.26.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rashmigottipati
Copy link
Member

/cherry-pick v1.25.x

@openshift-cherrypick-robot

@rashmigottipati: new pull request created: #6260

In response to this:

/cherry-pick v1.25.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rashmigottipati pushed a commit to rashmigottipati/operator-sdk that referenced this pull request Jan 25, 2023
…amework#6227)

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati added a commit that referenced this pull request Jan 25, 2023
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Co-authored-by: Bryce Palmer <bpalmer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants