Use digest instead of tags in scorecard images #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com>
acornett21
approved these changes
Apr 7, 2023
tkrishtop
reviewed
Apr 11, 2023
tkrishtop
approved these changes
Apr 11, 2023
Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com>
everettraven
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks @tonyskapunk for creating this PR! These changes look good to me!
/lgtm
Signed-off-by: Tony Garcia <tonyg@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
Thanks @everettraven I noticed the sanity test failed due to a pair of typos fixed in the last commit, whenever you have time I appreciate your review |
|
The docs sanity check is failing on an actually broken link but it will be fixed as part of #6394 Merging this |
oceanc80
pushed a commit
to oceanc80/operator-sdk
that referenced
this pull request
Apr 28, 2023
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com> * Update internal/cmd/operator-sdk/scorecard/cmd.go Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com> * Fix typo in image Signed-off-by: Tony Garcia <tonyg@redhat.com> --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
oceanc80
pushed a commit
to oceanc80/operator-sdk
that referenced
this pull request
Apr 28, 2023
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. Signed-off-by: Tony Garcia <tonyg@redhat.com> * Update internal/cmd/operator-sdk/scorecard/cmd.go Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Tony Garcia <tonyg@redhat.com> * Fix typo in image Signed-off-by: Tony Garcia <tonyg@redhat.com> --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com> Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
oceanc80
added a commit
that referenced
this pull request
Apr 28, 2023
* Use digest instead of tags in scorecard images The use of tags breaks disconnected environments when using mirrored images. * Update internal/cmd/operator-sdk/scorecard/cmd.go * Fix typo in image --------- Signed-off-by: Tony Garcia <tonyg@redhat.com> Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com> Co-authored-by: Tony Garcia <tonyskapunk@users.noreply.github.com> Co-authored-by: Tatiana Krishtop <tkrishto@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of tags breaks disconnected environments when using mirrored images.
Description of the change:
Reintroduces the use of Digest in the scorecard images instead of tags.
Motivation for the change:
Bring back default support to disconnected environments using scorecard.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
website/content/en/docsFixes: #6392