feat: allow operator-sdk install to be customizable #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhatrises
force-pushed
the
sdk_var_makefile
branch
from
8013a3d to
6c768b1
Compare
redhatrises
force-pushed
the
sdk_var_makefile
branch
from
6c768b1 to
542e137
Compare
|
@everettraven can you review? |
everettraven
approved these changes
Jun 7, 2023
|
@everettraven there seems to be some sort of issue with |
|
@everettraven anything else that needs to happen to this PR for it to be merged? |
- This allows the operator-sdk install to customizable via Makefile. If necessary, a specific version can be downloaded and used. Signed-off-by: Gabe Alford <redhatrises@gmail.com>
|
@redhatrises Nope, thanks for the ping as a reminder! Going to kick the docs test again, but will keep an eye on this to get it merged. |
redhatrises
force-pushed
the
sdk_var_makefile
branch
from
542e137 to
844209e
Compare
@everettraven FYI rebased against the master branch to pick up the fixed test (which removed the /lgtm) label. |
|
@everettraven after rebase, all tests green! yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This allows the operator-sdk install to customizable via Makefile. If necessary, a specific version can be downloaded and used.
Motivation for the change:
Useful for users to be able to customize their environment and usage of the operator-sdk binary in their project or project(s) e.g. a user works on multiple different projects that aren't on the same version, CI systems that might require a specific version, etc.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs