Allow users to add annotation to set configure rollback #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to add annotation, "helm.sdk.operatorframework.io/rollback-force", to set rollback to false. Default value is true Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
…-force annotation Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
OchiengEd
force-pushed
the
configurable-rollback
branch
from
de5931b
to
6bbe031
Compare
OchiengEd
force-pushed
the
configurable-rollback
branch
from
c549cbb
to
d16d463
Compare
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
OchiengEd
force-pushed
the
configurable-rollback
branch
from
d16d463
to
8321420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Whenever a helm-based operator encounters an error during reconcilliation, by default, it would attempt to perform a rollback with the
--forceoption. While this works as expected in most scenarios, there are a few edge cases where performing a rollback with--forcecould have undesired side effects.Adding annotation to the custom resource,
helm.sdk.operatorframework.io/rollback-force: falsetherefore allows a user, to change the default behavior of the helm-based operator whereby, rollbacks will be performed without the--forceoption whenever an error is encountered.%Motivation for the change:
This change was motivated by the issue #6494
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsCloses #6494