Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate #6842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgaist
Copy link

@sgaist sgaist commented Oct 12, 2024

Description of the change:

This PR adds the --ignore-not-found parameter to the kubectl call when calling make undeploy and make uninstall.

Motivation for the change:

This avoid the failure of either command if for some reason one or more of the kustomized resource is missing.

Part of #5195

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from anik120 and oceanc80 October 12, 2024 21:01
@sgaist sgaist force-pushed the 5195-add-ignore-not-found-to-undeploy branch 3 times, most recently from f27a4d4 to 6366640 Compare October 12, 2024 21:13
…boiler plate

This avoid failure of any of these two commands if for some
reason one or more of the kustomized resource is missing.

Part of 5195

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@sgaist sgaist force-pushed the 5195-add-ignore-not-found-to-undeploy branch from 6366640 to 666ed4f Compare October 12, 2024 21:19
@sgaist sgaist changed the title scripts: add ignore-not-found for undeploy to helm boiler plate scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant