Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use marker for markdown link verification #708

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Use marker for markdown link verification #708

merged 4 commits into from
Nov 5, 2018

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Use marker to verify link correctness.

Motivation for the change: Links in markdown are easy to mess up. This adds a new, quick travis job to verify that all markdown links are correct.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2018
@AlexNPavel
Copy link
Contributor Author

AlexNPavel commented Nov 5, 2018 •
edited
Loading

/hold
Marker should be fixed soon as the problem described in this issue was found and should be fixed soon: crawford/marker#16. I'll update this with the updated binary when that's ready

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2018
estroz
estroz approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after binary update.

@AlexNPavel
Copy link
Contributor Author

/hold remove
The issue in marker is a bit difficult to fix, so we'll just merge this PR as is now and update the marker binary at another time

@AlexNPavel
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2018
@AlexNPavel AlexNPavel merged commit 0af00eb into operator-framework:master Nov 5, 2018
@AlexNPavel AlexNPavel deleted the marker branch November 5, 2018 23:40
@AlexNPavel AlexNPavel mentioned this pull request Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz estroz approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexNPavel @hasbro17 @estroz @openshift-ci-robot