Use native showModal function as it is the new recommended way to c…

…all Primer::Dialogs from Javascript (see: primer/view_components#2581 (comment))
opf · Feb 16, 2024 · d9985aa · d9985aa
1 parent 6f524e9
commit d9985aa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...nd/src/stimulus/controllers/dynamic/storages/oauth-access-grant-nudge-modal.controller.ts b/...nd/src/stimulus/controllers/dynamic/storages/oauth-access-grant-nudge-modal.controller.ts
@@ -29,10 +29,9 @@
  */
 
 import { Controller } from '@hotwired/stimulus';
-import { ModalDialogElement } from '@openproject/primer-view-components/app/components/primer/alpha/modal_dialog';
 
-export default class OAuthAccessGrantNudgeModalController extends Controller<ModalDialogElement> {
+export default class OAuthAccessGrantNudgeModalController extends Controller<HTMLDialogElement> {
   connect() {
-    this.element.open = true;
+    this.element.showModal();
   }
 }
diff --git a/frontend/src/stimulus/controllers/dynamic/storages/open-project-storage-modal.controller.ts b/frontend/src/stimulus/controllers/dynamic/storages/open-project-storage-modal.controller.ts
@@ -30,9 +30,8 @@
 
 import { Controller } from '@hotwired/stimulus';
 import { renderStreamMessage } from '@hotwired/turbo';
-import { ModalDialogElement } from '@openproject/primer-view-components/app/components/primer/alpha/modal_dialog';
 
-export default class OpenProjectStorageModalController extends Controller<ModalDialogElement> {
+export default class OpenProjectStorageModalController extends Controller<HTMLDialogElement> {
   static values = {
     projectStorageOpenUrl: String,
     redirectUrl: String,
@@ -43,7 +42,7 @@ export default class OpenProjectStorageModalController extends Controller<ModalD
   redirectUrlValue:string;
 
   connect() {
-    this.element.open = true;
+    this.element.showModal();
     this.interval = 0;
     this.load();
     this.element.addEventListener('close', () => { this.disconnect(); });