-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent editing unwritable subject in CreateForm
Doing this by directly using the schema that previous code would have fetched via API. This seems to semantically make sense, because regardless of how we render a component, we should make sure to respect its schema. On the other hand, it feels weird to directly depend on any class from the API::V3 namespace in a non-API context.
- Loading branch information
1 parent
afed9c7
commit f177253
Showing
2 changed files
with
71 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
spec/components/work_packages/dialogs/create_form_component_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# frozen_string_literal: true | ||
|
||
# -- copyright | ||
# OpenProject is an open source project management software. | ||
# Copyright (C) 2010-2024 the OpenProject GmbH | ||
# | ||
# This program is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU General Public License version 3. | ||
# | ||
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: | ||
# Copyright (C) 2006-2013 Jean-Philippe Lang | ||
# Copyright (C) 2010-2013 the ChiliProject Team | ||
# | ||
# This program is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU General Public License | ||
# as published by the Free Software Foundation; either version 2 | ||
# of the License, or (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program; if not, write to the Free Software | ||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
# | ||
# See COPYRIGHT and LICENSE files for more details. | ||
# ++ | ||
|
||
require "rails_helper" | ||
|
||
RSpec.describe WorkPackages::Dialogs::CreateFormComponent, type: :component do | ||
subject(:render_component) { render_inline(described_class.new(work_package:, project: work_package.project)) } | ||
|
||
let(:work_package) { create(:work_package) } | ||
let(:user) { create(:admin) } | ||
|
||
before do | ||
User.current = user | ||
end | ||
|
||
it "enables the subject input" do | ||
render_component | ||
expect(page.find('input[name="work_package[subject]"]')).not_to be_disabled | ||
end | ||
|
||
context "when the user has no edit permissions" do | ||
let(:user) { User.anonymous } | ||
|
||
it "disables the subject input" do | ||
render_component | ||
expect(page.find('input[name="work_package[subject]"]')).to be_disabled | ||
end | ||
end | ||
|
||
context "when the work package subject is generated automatically" do | ||
let(:work_package) { create(:work_package, type:) } | ||
let(:type) { create(:type, patterns: { subject: { enabled: true, blueprint: "My Subject" } }) } | ||
|
||
it "disables the subject input" do | ||
render_component | ||
expect(page.find('input[name="work_package[subject]"]')).to be_disabled | ||
end | ||
end | ||
end |