Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51229] Remove feature flags for storage_primer_design and storage_one_drive_integration #14242

Conversation

ba1ash
Copy link
Member

@ba1ash ba1ash commented Nov 24, 2023

@ba1ash ba1ash self-assigned this Nov 24, 2023
Storages::Admin::StoragesController create action responds as a
turbo_stream only after storage_primer_design feature_flag removal.
They are broken due to removal of storage_primer_design feature flag.
Maybe they are not needed anymore.
@ba1ash ba1ash marked this pull request as ready for review November 24, 2023 17:28
@ba1ash ba1ash requested a review from a team November 24, 2023 17:35
Copy link
Contributor

@apfohl apfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clean now with all the components.

@apfohl apfohl merged commit a451e1f into dev Nov 27, 2023
@apfohl apfohl deleted the implementation/51229-remove-feature-flags-for-storage_primer_design-and-storage_one_drive_integration branch November 27, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants