Allow customization of the production database.yml #14286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
feature/production-database-yml
branch
from
a519fa3 to
69747f2
Compare
|
The single feature spec failure is certain not to be caused by a PR changing the database.yml so I've merged it despite that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For helm charts, it is useful to separate database options from the password credentials, so that they can be retrieved from e.g., a separate secret store. We currently do not support this as we require a single DATABASE_URL to be present.
But Rails actually allows you to merge a DATABASE_URL with separate configuration options in the database.yml. This PR allows you to do exactly this:
While we're at it, we allow all other options that currently require a lengthy
DATABASE_URLas separate env variables.