Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Primer to version 0.22.2 #14683

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Update Primer to version 0.22.2 #14683

merged 4 commits into from
Feb 18, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jan 31, 2024 •
edited
Loading

Known issues

  • The dropdown of the autocompleter is hidden behind Primer::Dialog (e.g. in the meetings dialog on the WP page)
    • Therefore the implementation of the autocomplete_select_decorator was changed to how it is defined here
  • Dialogs that are rendered without a trigger action are not correctly positioned. That is actually a bug in Primer itself, tracked here. Results in this:
Bildschirmfoto 2024-02-09 um 08 40 44

@HDinger HDinger added this to the 13.2.x milestone Jan 31, 2024
@HDinger HDinger force-pushed the housekeeping/bump-primer branch from 6f8763c to 57b20f8 Compare February 1, 2024 14:48
@HDinger HDinger changed the title Update Primer to version 0.21.0 Update Primer to version 0.22.0 Feb 1, 2024
@HDinger HDinger force-pushed the housekeeping/bump-primer branch from 57b20f8 to 31ee999 Compare February 5, 2024 12:56
@HDinger HDinger changed the title Update Primer to version 0.22.0 Update Primer to version 0.22.1 Feb 5, 2024
@HDinger HDinger force-pushed the housekeeping/bump-primer branch from 31ee999 to efc1c71 Compare February 8, 2024 08:54
@HDinger HDinger changed the base branch from release/13.2 to release/13.3 February 8, 2024 08:54
@HDinger HDinger force-pushed the housekeeping/bump-primer branch from a5eca18 to c789575 Compare February 9, 2024 12:37
@HDinger HDinger force-pushed the housekeeping/bump-primer branch from c789575 to 0ef47db Compare February 9, 2024 13:08
@HDinger HDinger removed this from the 13.2.x milestone Feb 13, 2024
@HDinger HDinger changed the title Update Primer to version 0.22.1 Update Primer to version 0.22.2 Feb 15, 2024
@HDinger HDinger added this to the 13.3.x milestone Feb 16, 2024
@oliverguenther oliverguenther merged commit 622ba72 into release/13.3 Feb 18, 2024
12 checks passed
@oliverguenther oliverguenther deleted the housekeeping/bump-primer branch February 18, 2024 19:38
@oliverguenther
Copy link
Member

I missed this bit, dialogs are now all rendered initially. I'll revert this PR for now.

Bildschirmfoto 2024-02-18 um 20 53 27

@oliverguenther oliverguenther mentioned this pull request Feb 18, 2024
Merged
@oliverguenther oliverguenther restored the housekeeping/bump-primer branch February 18, 2024 19:55
@oliverguenther oliverguenther mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

@akabiru akabiru Awaiting requested review from akabiru

Assignees
No one assigned
Labels
maintenance needs review
Milestone
13.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@HDinger @oliverguenther