-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[53466] Check for inconsistent interpolations in all i18n files #14946
Conversation
0c2e82b
to
8edaf3e
Compare
8edaf3e
to
130ff3e
Compare
555b75d
to
2f1b20f
Compare
2f1b20f
to
762dd99
Compare
762dd99
to
c5cdf9f
Compare
71 inconsistent interpolations remaining
output
|
c5cdf9f
to
d69b0ba
Compare
51 inconsistent interpolations remaining
output
|
d69b0ba
to
ec702b2
Compare
64 inconsistent interpolations remaining
output
|
ec702b2
to
0009fe4
Compare
8 inconsistent interpolations remaining
output
|
0009fe4
to
3fcbd8b
Compare
3 inconsistent interpolations remaining! They should now all be fixed at next run.
output
|
3fcbd8b
to
9b9a89f
Compare
🎉
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the configuration file is now duplicate. It's probably not a lot of maintenance, but just something I noticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good improvement.
There is just a single question, I'd like to raise.
https://community.openproject.org/wp/53466
AppSignal can sometimes detect missing interpolation in i18n strings in SaaS: https://appsignal.com/openproject-gmbh/sites/62b06dacd2a5e41321946fcf/exceptions/incidents/877/samples/timestamp/2024-03-07T13:29:18Z
It can be detected earlier with i18n-tasks gem:
This pull request modifies the existing
i18n_spec
and introduces another configuration file to not mess with the other i18n checks done.Now there are 130 interpolations to fix.
They have to be fixed in Crowdin directly.