Separate pt-BR and pt-PT through a crowdin custom mapping #14947
Conversation
oliverguenther
force-pushed
the
fix/portuguese-locales
branch
from
f1c4eb4 to
30f3049
Compare
Generated by 🚫 Danger |
oliverguenther
force-pushed
the
fix/portuguese-locales
branch
from
30f3049 to
6023119
Compare
Add all translations that have active translators, and are at or around 50% translation ratio. Do we perhaps want to enable all to improve translations, and mark those that have a bad ratio?
oliverguenther
force-pushed
the
fix/portuguese-locales
branch
from
6023119 to
acde5de
Compare
|
@ulferts please do not merge yet, I'm reviewing too. |
config/locales/generated/pt-BR.yml
Outdated
| # | ||
| # The translations come from version 42 of the Unicode CLDR project . | ||
| # | ||
| # The Unicode Common Locale Data Repository (CLDR) provides key building | ||
| # blocks for software to support the world's languages, with the largest | ||
| # and most extensive standard repository of locale data available. | ||
| --- | ||
| pt: | ||
| pt-BR: | ||
| cldr: | ||
| language_name: Português |
There was a problem hiding this comment.
It feels wrong. It should mention Brazil somewhere.
Actually, in the CLDR, there is no language information for pt-BR from file common/main/pt_BR.xml, and the way the script works fall back to pt locale from common/main/pt.xml file instead. That's why it's "Português".
The translations for variations "pt-BR" and "pt-PT" do not exist in common/main/pt.xml, but do exist in common/main/pt_PT.xml:
<language type="pt_BR">português do Brasil</language>
<language type="pt_PT">português europeu</language>
The correct language name should be "Português do Brasil".
We could also use the "territory" information from common/main/pt.xml to generate the names:
<territory type="BR">Brasil</territory>
...
<territory type="PT">Portugal</territory>
Names could then be "Português (Brasil)" and "Português (Portugal)".
Which one would be better?
The script should be modified to be better at automatically resolving those edge cases.
There was a problem hiding this comment.
I modified the script to use "Português do Brasil" instead and commited it.
|
@ulferts you can review a second time now, and merge if ok. |
|
Thanks @cbliard, I verified your changes |
Previously, both pt-BR and pt-PT in crowdin were active but mapped to the same pt.yml file. pt-BR "won" that and resulted in the only portuguese language being available.
On Crowdin, I added a custom mapping that would export both in the above locales like we already did for zh-TW and zh-CN. It requires a tiny migration to replace previous occurrrences of pt in user languages and default locales.
While I was adding to the default set of languages, I went through the list in crowdin and added all that are somewhat translated. Although I do believe we should add all languages (possibly with a warning if they are not translated well so far).
https://community.openproject.org/work_packages/53374/activity
To be able to reason about the default language selection, I've added that as a "Feature" so it turns up in the release notes, even though it's just that one line change.
https://community.openproject.org/work_packages/53378