[#53368] add authentication for storage interaction

[Kharonus]

#53368

WAT?

• Added the authentication class to storage interaction namespace
• added unit test that shows the usage and test the auth behaviour of all storage providers

[Kharonus]

ignore this method, I simply didn't want to cut this out into a separate commit. It is needed later, when authorization state is extracted from the connection manager

[mereghost]

From what I see you have the usage be somewhat like so:

CreateTemplateFolderCommand.call(auth: Strategy.new(:oauth_client_credentials), storage: ....)

# or on the inside of an object
class RmRfCommand
  def call(strategy: :basic_auth, storage:, location:)
     Authentication[strategy].call do |authed_http_session|
       do_awesome_requests
     end
  end
end

[mereghost]

🔴 You can actually mock a timeout with WebMock

stub_request(:get, 'https://timeout-as-a-service.com/').to_timeout

[Kharonus]

True, that spec was part of the query tests before, hence webmock was no option (interfering with vcr).

I can change that now.

[Kharonus]

Update: I will refactor that test with the first query that is moved to new auth strategies. Right now, I don't see a good sense in this whole test :/

I wanted to cover the behaviour of httpx to return network errors in a different object. But the handling of it happens inside the queries. So, I would suggest to add a network unit test with webmock, that runs on top of an example query, which is considered a placeholder for all other queries, too.