Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace manual job checking for GoodJob concurrency checks #14992

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Replace manual job checking for GoodJob concurrency checks #14992

merged 1 commit into from
Mar 18, 2024

Conversation

oliverguenther
Copy link
Member

Replaces the manual query for the job with good_job concurrency controls. To make this work in the test environment, we have to enqueue the job with GoodJob itself, which is not the default.

https://community.openproject.org/work_packages/53122

@oliverguenther oliverguenther requested a review from ba1ash March 13, 2024 10:04
@oliverguenther oliverguenther force-pushed the chore/53122/replace-concurrency-check-with-good-job branch 2 times, most recently from ab0335f to afe0418 Compare March 13, 2024 10:05
@oliverguenther
Replace manual job checking for GoodJob concurrency checks
a5bcba9 
Replaces the manual query for the job with good_job concurrency controls.
To make this work in the test environment, we have to enqueue the job with GoodJob itself,
which is not the default.

https://community.openproject.org/work_packages/53122
@oliverguenther oliverguenther force-pushed the chore/53122/replace-concurrency-check-with-good-job branch from afe0418 to a5bcba9 Compare March 13, 2024 10:13
ba1ash
ba1ash approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@ba1ash ba1ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ba1ash ba1ash merged commit 7b02616 into dev Mar 18, 2024
9 checks passed
@ba1ash ba1ash deleted the chore/53122/replace-concurrency-check-with-good-job branch March 18, 2024 10:00
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 18, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
af291cb 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 18, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
8024b12 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 19, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
dbb4b7e 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 19, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
10fb3c1 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 19, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
f285762 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 19, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
d8de76a 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 19, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
e1353b7 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
8f08608 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
6dda280 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
d0a73fd 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
150305b 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
7425891 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
199e782 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
2704818 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
974044e 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 22, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
1c943c0 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 23, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
01b7991 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 23, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
a9dd196 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 24, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
ebf8e41 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 25, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
efb13fd 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 25, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
8952ed6 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
e8d92a0 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
9d30067 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
d832c64 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 27, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
b7267f0 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 27, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
5db48ec 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 28, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
c9c94c9 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 28, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
fe26300 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 29, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
b150918 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 1, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
2276d38 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 1, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
5b0d970 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
17b4cea 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
0290391 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
431103a 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
ef033ee 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
81f3433 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
feb8813 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
ba13489 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#14992 from opf/chore/53122/replace-con…
5754671 
…currency-check-with-good-job"

This reverts commit 7b02616, reversing
changes made to 024376a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ba1ash ba1ash ba1ash approved these changes

Assignees
No one assigned
Labels
maintenance needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @ba1ash