Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky schedule date alerts notifications job spec #15040

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Flaky schedule date alerts notifications job spec #15040

merged 4 commits into from
Mar 20, 2024

Conversation

toy
Copy link
Contributor

@toy toy commented Mar 19, 2024 •
edited
Loading

Starting with 18:15 utc(?) there is an extra Notifications::WorkflowJob created for Kathmandu time zone test which fails the change count test.

Am I correcting the right thing?

toy added 3 commits March 19, 2024 14:09
@toy
remove unused default values
fc2645d
@toy
check job count only with specific job_class
a5b6425 
Starting with 18:15 there is an extra Notifications::WorkflowJob created for
Kathmandu time zone test which fails the change count test.
@toy
rubocop
b30fd5b
@toy toy requested review from oliverguenther and ulferts March 19, 2024 13:57
ulferts
ulferts approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good.

Extra points for changing the string into the constant. But merge at will since that is minor.

spec/workers/notifications/schedule_date_alerts_notifications_job_spec.rb Outdated Show resolved Hide resolved
@toy toy merged commit 2acc3ad into dev Mar 20, 2024
9 checks passed
@toy toy deleted the flaky-schedule_date_alerts_notifications_job_spec branch March 20, 2024 11:20
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
8853263 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 20, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
32ce87c 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
5fb04da 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
7b95366 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
0dde0a0 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 21, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
c9a2c65 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 22, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
975056a 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 23, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
1a7f08e 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 23, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
aa669ee 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 24, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
aba47f5 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 25, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
922c670 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 25, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
93eabb8 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
a158afc 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
5858631 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 26, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
114c342 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 27, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
882f0dc 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 27, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
d35e8a4 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 28, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
b202961 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 28, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
378ed6a 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Mar 29, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
bbc4f42 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 1, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
cb53606 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 1, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
da4e792 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
b0f6687 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
9519c40 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 2, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
4f66568 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
5fb2ac1 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
76fd3cf 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
9c874d8 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
b76dd90 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Apr 3, 2024
@Eric-Guo
Revert "Merge pull request opf#15040 from opf/flaky-schedule_date_ale…
d95b4ef 
…rts_notifications_job_spec"

This reverts commit 2acc3ad, reversing
changes made to 691c2d6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulferts ulferts ulferts approved these changes

@oliverguenther oliverguenther Awaiting requested review from oliverguenther

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toy @ulferts